Findbugs issue with “Boxing/unboxing to parse a primitive” with Integer.valueOf(String)

by

The issue is that Integer.valueOf returns an Integer, not an int, but your someOtherMethod expects an int. Findbugs is basically warning you that you’re doing it a long-winded way that involves potentially creating an object (the Integer) that you don’t need which you’re then immediately going to unbox by passing it to someOtherMethod(int), e.g.:

String => int => Integer => int
          ^^^^^^^^^^^^^^
                \--- This is inside Integer.valueOf

Instead, you can and probably should avoid that unnecessary round-trip through Integer and simply do:

String => int
^^^^^^^^^^^^^
      \--- Integer.parseInt

There’s just no need for the temporary Integer and the potential memory allocation and such surrounding it.

If someOtherMethod were expecting an Integer, you wouldn’t get the warning, because the Integer isn’t purely temporary.

This is just one of a class of unnecessary-boxing-conversions that Findbugs and tools like it helpfully point out.

Related Contents:

  1. How to convert int[] into List in Java?
  2. Turning Sonar off for certain code
  3. Is there a way to ignore a single FindBugs warning?
  4. Convert an array of primitive longs into a List of Longs
  5. What are the differences between PMD and FindBugs?
  6. Differences in auto-unboxing between Java 6 vs Java 7
  7. Checkstyle vs. PMD
  8. How to convert byte[] to Byte[] and the other way around?
  9. Why comparing Integer with int can throw NullPointerException in Java?
  10. How to handle a Findbugs “Non-transient non-serializable instance field in serializable class”?
  11. How do I get an IntStream from a List?
  12. Incorrect lazy initialization
  13. In Java 8, is there a ByteStream class?
  14. Difference in behaviour of the ternary operator on JDK8 and JDK10
  15. javax.annotation: @Nullable vs @CheckForNull
  16. Does autoboxing call valueOf()?
  17. ResultSet not closed when connection closed?
  18. @GuardedBy annotation with java.util.concurrent.locks.ReadWriteLock
  19. How to use an existing database with an Android application [duplicate]
  20. How to convert a double to long without casting?
  21. Hibernate – Batch update returned unexpected row count from update: 0 actual row count: 0 expected: 1
  22. Integer.toString(int i) vs String.valueOf(int i)
  23. Difference between Iterator and Listiterator?
  24. Simple Getter/Setter comments
  25. Maven package works but Intellij’s build fails
  26. Force point (“.”) as decimal separator in java
  27. How to set Spring profile from system variable?
  28. How to convert AAR to JAR
  29. Spring-Boot: How do I set JDBC pool properties like maximum number of connections?
  30. How to get backspace \b to work in Eclipse’s console?
  31. Why does the Maven command “mvn sonar:sonar” work without any plugin configuration in my “pom.xml”?
  32. How to use getMethod() with primitive types?
  33. Creating a bundle jar with ant
  34. Exception without stack trace in Java
  35. Maven adding mainClass in pom.xml with the right folder path
  36. Java interface throws an exception but interface implementation does not throw an exception?
  37. Difference between @Size, @Length and @Column(length=value) when using JPA and Hibernate
  38. Hash : How does it work internally?
  39. What’s the difference between jaxws-ri and jaxws-rt?
  40. What is the difference between synchronized on lockObject and using this as the lock?
  41. How to enable wire logging for a java HttpURLConnection traffic?
  42. Expiry time @cacheable spring boot
  43. StringBuffer is obsolete?
  44. Spring security with Oauth2 or Http-Basic authentication for the same resource
  45. Set folder for classpath [duplicate]
  46. How to get a Stream from a float[]
  47. How to load a classpath resource to an array of byte?
  48. Hibernate/JPA DB Schema Generation Best Practices
  49. Making package-protected java class visible in parent package
  50. String replace a Backslash

Leave a Comment